Update backend routes for events #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhvy
requested changes
Jul 3, 2025
jason4193
reviewed
Jul 8, 2025
Closed
fox-58
force-pushed
the
update-backend-routes-for-events
branch
2 times, most recently
from
896e5a9 to
e6bf72a
Compare
lhvy
requested changes
Sep 4, 2025
| const colourValid = this.isColourCodeValid(eventDetails.colour); | ||
| validate(colourValid, 'Colour code is not valid', HttpStatus.BAD_REQUEST); | ||
|
|
||
| if (!(eventDetails.type in EventType)) { |
Contributor
There was a problem hiding this comment.
Curious if this is actually possible. Might be worth testing to see what happens when you pass an invalid type... Ask @jason4193 about using Postman later.
Contributor
There was a problem hiding this comment.
@lhvy Tested on the Postman, only default-<1 to 8>, #<3 letters 0-9/A-F> & #<6 letters 0-9/A-F> will pass the validation.
Something like #default, default-9, #xxx will fail
mark-trann
reviewed
Sep 4, 2025
fox-58
force-pushed
the
update-backend-routes-for-events
branch
from
75fe2be to
3cfa62f
Compare
lhvy
requested changes
Oct 8, 2025
fox-58
force-pushed
the
update-backend-routes-for-events
branch
from
258dcf4 to
f353af6
Compare
lhvy
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🧾
Context of PR, summary of changes, as well as any relevant technical decisions/motivations.
Testing
Replace this line with instructions on how to test your changes, as well as any relevant images for UI changes.
Checklist
feature: for application feature improvement or new featuresbug: fixing something that previously wasn't workingdev: development-side related changesdocker: updates to the Docker codesetup: changes to the setup/infrastructure of the codebasetest: updates to internal testing