Skip to content

More aggressively catch corrupted local storage #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

More aggressively catch corrupted local storage #1031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d842d11
More aggressively catch corrupted local storage
lhvy Jul 15, 2025
a53e052
Address review comments
lhvy Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/src/utils/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ import { createDefaultTimetable } from './timetableHelpers';

const STORAGE_KEY = 'data';

// Something is not playing nice and causing local storage to corrupt across signing in/out
// We are in the process of migrating data to the backend, so this fix should catch people
// for now and prevent them from seeing a blank page.
let hasRunArrayCheck = false;

const storage = {
get: (key: string): any => {
const data: Record<string, any> = storage.load();
Expand Down Expand Up @@ -64,7 +69,7 @@ const storage = {
}

// Un-break an existing issue with migrated data
if (migrated.version == null || migrated.version < 2) {
if (!hasRunArrayCheck) {
Object.entries(migrated.timetables).forEach(([term, timetables]) => {
if (
!Array.isArray(timetables) ||
Expand All @@ -73,6 +78,9 @@ const storage = {
migrated.timetables[term] = createDefaultTimetable('');
}
});

storage.save(migrated);
hasRunArrayCheck = true;
}

// only do this if version does not exist
Expand Down