Friends sidebar #1070
Merged
Friends sidebar #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot part of scroll
Closed
…d hover to support future click-on-friend operation
…on form immediately
lhvy
approved these changes
Sep 17, 2025
lhvy
pushed a commit
that referenced
this pull request
Sep 17, 2025
* Remove old friends implementation * Add togglable friends * Move sidebar collapsed state to app context * Remove another old friend component * Add friend list and search bar * Refactor sidebar's collapsed state into an AppContext * MVP of friends list with simple search * reverting auth guard lol * Refactor sidebar styled and fix user account padding * Fix friends list scroll issue * Fix sidebar always scrolling * Remaster the add friends button * Move scrollable component down by 1 layer so that notangles logo is not part of scroll * Add todo comment * undo changes for auth on server * Fix search and add friend buttons on sidebar for collapsed. Also added hover to support future click-on-friend operation * Clicking search button on collapsed sidebar will expand it and focus on form immediately * Hide sidebar scroll (removes weird ui bug in collapsed as well) * Remove empty tag wraps --------- Co-authored-by: Mark Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🧾
Reckon this is good enough to get some parallel work going. Managed to only do simple substring searching for friends (fuzzy search todo). Friends list is scrollable. Did some refactor of the UserProfile component to make it more reusable.
Testing
Works fine with dark mode too.
Checklist
feature: for application feature improvement or new featuresbug: fixing something that previously wasn't workingdev: development-side related changesdocker: updates to the Docker codesetup: changes to the setup/infrastructure of the codebasetest: updates to internal testing