Skip to content

Conversation

@mere-z
Copy link
Contributor

@mere-z mere-z commented Oct 21, 2025

Description 🧾

Introduces shortening logic to the Name display in the sidebar. (the shortening logic calculates thewidth of text that is 14.8px, 400 font weight, roboto helvetica etc font family, normal word spacing. those correspond to the current font for the name).

Testing

Testing has been done with a mix of short/long words, feel free to try yourself
iiiiiiiiiiiiiiiiiiiiiiiii
eeeeeeiiiiiiiiii
Abcdefghilsf
WWWWWW

etc.

Checklist

  • 📍 You have assigned yourself to this pull request.
  • 🔗 You have linked an issue to which this pull request closes.
  • 💭 Leave any relevant specific directions to reviewers.
  • 👀 No secrets in clear text in the pull request.
  • 🎟️ To categorise release notes, the pull request should be labelled with at least one of these labels:
    • feature: for application feature improvement or new features
    • bug: fixing something that previously wasn't working
    • dev: development-side related changes
    • docker: updates to the Docker code
    • setup: changes to the setup/infrastructure of the codebase
    • test: updates to internal testing

@mere-z mere-z requested review from a team as code owners October 21, 2025 21:39
@mere-z mere-z added the 🐞 bug 🐛 Something isn't working label Oct 21, 2025
@mere-z mere-z self-assigned this Oct 21, 2025
@lhvy lhvy changed the base branch from dev to server-rewrite October 22, 2025 01:28
Copy link
Contributor

@mark-trann mark-trann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nitpicks only but otherwise lgtm! ty for changes

Copy link
Contributor

@mark-trann mark-trann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amen

@mark-trann mark-trann merged commit 9e11b16 into server-rewrite Oct 29, 2025
3 checks passed
@mark-trann mark-trann deleted the fix-sidebar-name-display branch October 29, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants