Skip to content

Build With Dockerfile template and without dockerfile(using buildpack) #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Nov 4, 2022

Conversation

kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Nov 1, 2022

Description

Build Project using Buildpack or can select from Dockerfile templates

Fixes #2561

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Build sample Projects for different languages using buildpack
  • Build sample projects using Dockerfile templates.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kripanshdevtron kripanshdevtron self-assigned this Nov 1, 2022
Copy link
Member

@nishant-d nishant-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make changes in dockerfile/Makefile to ensure our Unit tests are being invoked every-time we are triggering a release

nishant-d
nishant-d previously approved these changes Nov 4, 2022
@sohel-rp sohel-rp merged commit 1569890 into main Nov 4, 2022
@sohel-rp sohel-rp deleted the buildpack-support branch November 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Build Project using Dockerfile templates or without Dockerfile (using Buildpack)
4 participants