Skip to content

Conversation

tautschnig
Copy link
Collaborator

The code in src/linking supposedly deals with symbol tables only, not
with goto programs (goto-programs/link_goto_model does this).
Consequently, static lifetime init should not create codet structures
defined in goto-programs/goto_instruction_code.h.

This is a first step to remove the goto-programs dependency from
src/linking.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #6554 (13d86b0) into develop (7965ba2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6554      +/-   ##
===========================================
- Coverage    76.64%   76.64%   -0.01%     
===========================================
  Files         1579     1579              
  Lines       181479   181476       -3     
===========================================
- Hits        139101   139098       -3     
  Misses       42378    42378              
Impacted Files Coverage Δ
src/linking/static_lifetime_init.cpp 98.63% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2240be...13d86b0. Read the comment docs.

The code in src/linking supposedly deals with symbol tables only, not
with goto programs (goto-programs/link_goto_model does this).
Consequently, static lifetime init should not create codet structures
defined in goto-programs/goto_instruction_code.h.

This is a first step to remove the goto-programs dependency from
src/linking.
Copy link

@chris-ryder chris-ryder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@chris-ryder chris-ryder removed their assignment Feb 5, 2022
@tautschnig tautschnig merged commit bfdbce9 into diffblue:develop Feb 5, 2022
@tautschnig tautschnig deleted the linking-assign branch February 5, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants