Skip to content

fix npe in webhook that was accidental #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix npe in webhook that was accidental #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions next/controllers/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,14 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
if *event.Action == "deleted" {
err := handleInstallationDeletedEvent(event)
if err != nil {
c.String(http.StatusInternalServerError, "Failed to handle webhook event.")
log.Printf("Failed to handle webhook event. %v", err)
return
}
}

c.String(http.StatusAccepted, "ok")
return

case *github.IssueCommentEvent:
log.Printf("IssueCommentEvent, action: %v\n", *event.Action)
case *github.PullRequestEvent:
Expand All @@ -81,7 +84,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
if err != nil {
log.Printf("handlePullRequestEvent error: %v", err)
}
c.String(http.StatusAccepted, err.Error())
c.String(http.StatusAccepted, "ok")
return

case *github.PushEvent:
Expand All @@ -90,7 +93,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
if err != nil {
log.Printf("handlePushEvent error: %v", err)
}
c.String(http.StatusAccepted, err.Error())
c.String(http.StatusAccepted, "ok")
return

default:
Expand Down
Loading