VC is throwing exception instead of returning result when credential is expired

[fabrii]

When credential is revoked, vc returns the following object:

{"log": [{"id": "valid_signature", "valid": true},
{"id": "issuer_did_resolves", "valid": true},
{"id": "expiration", "valid": true},
{"id": "revocation_status", "valid": false}],
"results": [{"error": undefined, "log": [Array], "proof": [Object], "purposeResult": [Object], "verificationMethod": [Object], "verified": true}], "statusResult": {"results": [[Object]], "verified": false},
"verified": false}

When credential is expired, vc returns

{"error": [Error: Credential has expired.], "results": [{"credential": [Object], "error": [Error: Credential has expired.], "verified": false}], "verified": false}

VC should return a similar object as the first case with {"id": "expiration", "valid": false}
This has impact in learner credential: https://github.com/openwallet-foundation-labs/learner-credential-wallet/blob/8f9184309c770c015a63579bdb47d9d3ce5d4b93/app/lib/validate.ts#L83

When credential is expired, a generic Error is thrown, and the reason is lost.

[fabrii]

This was working correctly with vc 7.0.0, but stopped working with vc 8.0.0.

I tracked down the issue to this commit b97ca64

In particular, it changed this line

Meanwhile, in learner credential, at https://github.com/openwallet-foundation-labs/learner-credential-wallet/blob/8f9184309c770c015a63579bdb47d9d3ce5d4b93/app/lib/validate.ts#L82 it is checked that the log entry should exist. If it doesn´t, it throws a generic error.

@dmitrizagidulin
@kezike

[fabrii]

Hi @alexfigtree. Any updates on this?

I think just adding the log: error.log to results array would be sufficient to fix this error.

Btw, this can be also fixed at Learner Credential Wallet, adding these lines:

if (result.results?.[0].error){
    result.results[0].log = result.results[0].error.log;
}

before https://github.com/openwallet-foundation-labs/learner-credential-wallet/blob/8f9184309c770c015a63579bdb47d9d3ce5d4b93/app/lib/validate.ts#L82

Thank you

[jchartrand]

@fabrii Your screenshot from above, i.e.,

Shows where the 'log: error.log' was removed from the result, but that is because the log was still available in the 'error' property. In other words, including the extra 'log' property was just duplicating what was already in the error.

And I think you make the same point in your Apr 15 comment where you show how the log can be gotten from the error.

Note too that we are reworking the Learner Credential Wallet to use a new verification package: https://github.com/digitalcredentials/verifier-core that wraps the VC lib and does a few other things, and so the reworked logic in the wallet will better handle expiration.

Does this address your issue?

[fabrii]

Hello @jchartrand.

Yes, I am closing this issue, as this could be handled at consumer level.

Thank you