-
Notifications
You must be signed in to change notification settings - Fork 71
Adjusted dark mode #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adjusted dark mode #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adjusts the dark mode visuals by conditionally loading different assets and updating theme colors for improved user experience. Key changes include:
- Conditionally rendering dark mode logos in Home.tsx.
- Updating the dark mode background color in DateRange.tsx.
- Revising theme configuration and style overrides in App.tsx for dark mode support.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/pages/Home.tsx | Adds conditional rendering to display a dark mode logo when the theme is in dark mode. |
| src/components/DateRange.tsx | Changes the dark mode background color from '#1E1E1E' to '#242424'. |
| src/App.tsx | Updates theme definitions and component style overrides with new dark mode color variables. |
Comments suppressed due to low confidence (1)
src/App.tsx:238
- Consider replacing 'default' with theme.palette.background.default to ensure the correct light mode background color is applied.
<Stack sx={{backgroundColor: (theme) => (theme.palette.mode === 'light' ? 'default' : darkBg2)}} marginTop="auto" p={2}>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the "after" picture harder to read, but approving since it passes objective accessibility guidelines--thanks for testing those. Ship it!
For future subjective style changes, maybe worth throwing a poll in #seceng-core to gauge user sentiment.
|
I agree that the text is a bit harder to read, is it possible to brighten the text a bit more so the contrast is a bit higher against the background? |
Text to background contrast passes WCAG (Web Content Accessibility Guidelines) AAA for all background and text colors
Before:

After:

Light mode remains unchanged