Skip to content

Conversation

@eguerrant
Copy link
Contributor

@eguerrant eguerrant commented May 22, 2025

Text to background contrast passes WCAG (Web Content Accessibility Guidelines) AAA for all background and text colors

Before:
Screenshot 2025-05-23 at 1 33 27 PM

After:
Screenshot 2025-10-24 at 2 05 22 PM

Light mode remains unchanged

Copilot AI review requested due to automatic review settings May 22, 2025 18:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the dark mode visuals by conditionally loading different assets and updating theme colors for improved user experience. Key changes include:

  • Conditionally rendering dark mode logos in Home.tsx.
  • Updating the dark mode background color in DateRange.tsx.
  • Revising theme configuration and style overrides in App.tsx for dark mode support.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

File Description
src/pages/Home.tsx Adds conditional rendering to display a dark mode logo when the theme is in dark mode.
src/components/DateRange.tsx Changes the dark mode background color from '#1E1E1E' to '#242424'.
src/App.tsx Updates theme definitions and component style overrides with new dark mode color variables.
Comments suppressed due to low confidence (1)

src/App.tsx:238

  • Consider replacing 'default' with theme.palette.background.default to ensure the correct light mode background color is applied.
<Stack sx={{backgroundColor: (theme) => (theme.palette.mode === 'light' ? 'default' : darkBg2)}} marginTop="auto" p={2}>

Copy link
Contributor

@barborico barborico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the "after" picture harder to read, but approving since it passes objective accessibility guidelines--thanks for testing those. Ship it!

For future subjective style changes, maybe worth throwing a poll in #seceng-core to gauge user sentiment.

@somethingnew2-0
Copy link
Collaborator

I agree that the text is a bit harder to read, is it possible to brighten the text a bit more so the contrast is a bit higher against the background?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants