Skip to content

Conversation

Baltrunas
Copy link
Contributor

msgid "Name" and msgid "Key" vas same translation as "Name", also it has negative effect for other modules

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1505 (8298d50) into main (488d305) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   85.87%   85.71%   -0.16%     
==========================================
  Files          35       35              
  Lines        1883     1883              
  Branches      313      313              
==========================================
- Hits         1617     1614       -3     
- Misses        187      190       +3     
  Partials       79       79              
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 85.41% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488d305...8298d50. Read the comment docs.

@tim-schilling
Copy link
Member

I'm not sure why I triggered the tests. We need to make this change via Transifex. Let me get that squared away.

@matthiask
Copy link
Member

I agree, this is a better translation.

(Maybe pgettext should be used more often...)

Baltrunas and others added 2 commits December 4, 2021 13:01
msgid "Name" and msgid "Key" vas same translation as "Name", also it has negative effect for other modules
@tim-schilling tim-schilling merged commit 0c039c6 into django-commons:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants