Skip to content

Conversation

@tim-schilling
Copy link
Member

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@tim-schilling
Copy link
Member Author

tim-schilling commented Jul 23, 2023

This is failing due to python/cpython#107088 which causes <listcomp> to no longer appear in the cProfile stats. On the plus side, we can likely remove this test for future versions of python if that's the case. Though ideally we'd have a better way to tell a user that this code is a problem.

Co-authored-by: Matthias Kestenholz <[email protected]>
@tim-schilling
Copy link
Member Author

This is blocked by psycopg/psycopg#626

We could bypass this by using psycopg

Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like psycopg released a compatible package so the CI can be rerun.

@tim-schilling tim-schilling merged commit 036e8db into django-commons:main Oct 14, 2023
@tim-schilling tim-schilling deleted the python-3.12 branch October 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants