Skip to content

Avoid setting color-scheme on :root, we're only a guest on pages #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2024
Merged

Avoid setting color-scheme on :root, we're only a guest on pages #1923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cf61f6
Avoid setting color-scheme on :root, we're only a guest on pages
matthiask May 27, 2024
5ef2643
Add a changelog entry
matthiask May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions debug_toolbar/static/debug_toolbar/css/toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
monospace, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol",
"Noto Color Emoji";

color-scheme: light;
--djdt-font-color: black;
--djdt-background-color: white;
--djdt-panel-content-background-color: #eee;
Expand All @@ -35,7 +34,6 @@

@media (prefers-color-scheme: dark) {
:root {
color-scheme: dark;
--djdt-font-color: #8393a7;
--djdt-background-color: #1e293bff;
--djdt-panel-content-background-color: #0f1729ff;
Expand All @@ -58,7 +56,6 @@
}

#djDebug[data-theme="dark"] {
color-scheme: dark;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this one have stayed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and I'm not sure what it even does since we're basically specifying all colors and backgrounds. Yes, it could stay, but then we'd also have to set the opposite on #djDebug[data-theme="light"] (I think)

The bigger point here is that while I do have much experience with CSS generally I don't really know how the color-scheme property behaves, and it felt safer to just remove it at this time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright that's fair.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, sorry for pressing ahead, I wanted to release a better version quickly instead of waiting for more reports.

--djdt-font-color: #8393a7;
--djdt-background-color: #1e293bff;
--djdt-panel-content-background-color: #0f1729ff;
Expand Down
2 changes: 2 additions & 0 deletions docs/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Change log
Pending
-------

* Removed some CSS which wasn't carefully limited to the toolbar's elements.


4.4.1 (2024-05-26)
------------------
Expand Down