Skip to content

Conversation

bmispelon
Copy link
Member

@bmispelon bmispelon commented Feb 18, 2024

This new script should prevent silent breakage of plugins like we experienced recently (#179).

This PR consists of two commits:

  1. The first one adds the script, along with a .TRACFREEZE.txt "lock" file and the associated CI check that makes sure the list of actually installed components does not change.
  2. The second commit cleans up the linting errors, removing outdated entries from [components]. The first commit guarantees that those removed lines did not affect the installation.

@bmispelon bmispelon force-pushed the script-traccheck branch 2 times, most recently from 480810e to 838083f Compare February 18, 2024 12:17
@bmispelon bmispelon requested a review from felixxm February 18, 2024 12:23
This was referenced Feb 18, 2024
@felixxm felixxm changed the title Added traccheck.py (utilities to prevent Trac from breaking silently) Added tests for list of installed components. Feb 21, 2024
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmispelon Thanks 👍 I pushed tiny edits.

@felixxm felixxm merged commit 8a603c8 into django:main Feb 21, 2024
@bmispelon
Copy link
Member Author

@bmispelon Thanks 👍 I pushed tiny edits.

Excellent, thanks! Do you know if there's a way for me to see the edits you've made? It doesn't really matter, but I'm curious 😁

@bmispelon bmispelon deleted the script-traccheck branch February 21, 2024 11:07
@felixxm
Copy link
Member

felixxm commented Feb 21, 2024

@bmispelon Thanks 👍 I pushed tiny edits.

Excellent, thanks! Do you know if there's a way for me to see the edits you've made? It doesn't really matter, but I'm curious 😁

https://github.com/django/code.djangoproject.com/compare/838083ff8790585aeb081c585898331e5b88f0b7..8a603c8f7b660ead6e1e56ed51f071c945e4b60a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants