Skip to content

Conversation

@AntonOks
Copy link
Contributor

@AntonOks AntonOks commented Jun 7, 2020

Add the keyring update info, which is a continuous reoccurring confusion, see also https://forum.dlang.org/post/[email protected]

Add the keyring update info, which is a continuous reoccurring confusion, see also https://forum.dlang.org/post/[email protected]
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @AntonOks! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Though we really should improve the installer to auto-update or detect when the keyring/script has been upgraded.

@dlang-bot dlang-bot merged commit b4c3ae3 into dlang:master Jun 7, 2020
@AntonOks
Copy link
Contributor Author

AntonOks commented Jun 7, 2020

Thanks! Though we really should improve the installer to auto-update or detect when the keyring/script has been upgraded.

true.
can you point me to the install.sh script?

@AntonOks AntonOks deleted the patch-1 branch June 7, 2020 19:13
@wilzbach
Copy link
Contributor

wilzbach commented Jun 7, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants