Skip to content

Fix Issue 18044: std.conv.to for implicitly convertible associative arrays #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Fix Issue 18044: std.conv.to for implicitly convertible associative arrays #5909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion std/conv.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ Associative array to associative array conversion converts each key
and each value in turn.
*/
private T toImpl(T, S)(S value)
if (isAssociativeArray!S &&
if (!isImplicitlyConvertible!(S, T) && isAssociativeArray!S &&
isAssociativeArray!T && !is(T == enum))
{
/* This code is potentially unsafe.
Expand Down Expand Up @@ -1619,6 +1619,16 @@ if (isAssociativeArray!S &&
auto d = to!(immutable(short[immutable wstring])[immutable string[double[]]])(c);
}

@safe unittest
{
import std.algorithm.comparison : equal;
import std.array : byPair;

int[int] a;
assert(a.to!(int[int]) == a);
assert(a.to!(const(int)[int]).byPair.equal(a.byPair));
}

private void testIntegralToFloating(Integral, Floating)()
{
Integral a = 42;
Expand Down