This repository was archived by the owner on Nov 27, 2023. It is now read-only.
ACI: Allow setting protocol when publishing ports #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Dec 11, 2020
aci/convert/ports.go
Outdated
| groupProtocol = containerinstance.UDP | ||
| containerProtocol = containerinstance.ContainerNetworkProtocolUDP | ||
| default: | ||
| return nil, nil, nil, fmt.Errorf("Unknown protocol %q in exposed port for service %q", portConfig.Protocol, service.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil, nil, nil, fmt.Errorf("Unknown protocol %q in exposed port for service %q", portConfig.Protocol, service.Name) | |
| return nil, nil, nil, fmt.Errorf("unknown protocol %q in exposed port for service %q", portConfig.Protocol, service.Name) |
Contributor
Author
There was a problem hiding this comment.
... can't put this in my head ! :) fixed
Signed-off-by: Guillaume Tardif <[email protected]>
gtardif
force-pushed
the
aci_udp_ports
branch
from
67ba4e0 to
5f73043
Compare
Contributor
|
|
rumpl
approved these changes
Dec 14, 2020
ndeloof
approved these changes
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Tardif [email protected]
What I did
docker inspectalso returns the correct port protocol.Related issue
Fixes #985
/test-aci
(not mandatory) A picture of a cute animal, if possible in relation with what you did