Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

@thaJeztah
Copy link
Member

see docker/cli#3131

Changes:

  • winterm: GetStdFile(): Added compatibility with "golang.org/x/sys/windows"
  • winterm: fix GetStdFile() falltrough
  • update deprecation message to refer to the correct replacement

full diff:

Signed-off-by: Sebastiaan van Stijn [email protected]

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Changes:

- winterm: GetStdFile(): Added compatibility with "golang.org/x/sys/windows"
- winterm: fix GetStdFile() falltrough
- update deprecation message to refer to the correct replacement

full diff:

- moby/term@bea5bbe...9d4ed18
- Azure/go-ansiterm@d6e3b33...2377c96

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@ndeloof ndeloof merged commit 1343bc5 into docker-archive:main Jun 10, 2021
@thaJeztah thaJeztah deleted the bump_term branch June 10, 2021 15:26
@thaJeztah
Copy link
Member Author

Heads up; I don't think we build for Windows on ARM for this repo, so should not be a big issue, but it looks like there's an issue with the Azure/go-ansiterm update;

#16 1.834 Building static docker-windows-arm-v7.exe
#16 110.1 # github.com/docker/cli/vendor/github.com/Azure/go-ansiterm/winterm
#16 110.1 vendor/github.com/Azure/go-ansiterm/winterm/ansi.go:167:2: constant 4294967286 overflows int
#16 110.1 vendor/github.com/Azure/go-ansiterm/winterm/ansi.go:169:2: constant 4294967285 overflows int
#16 110.1 vendor/github.com/Azure/go-ansiterm/winterm/ansi.go:171:2: constant 4294967284 overflows int
#16 ...

@ndeloof
Copy link
Collaborator

ndeloof commented Jun 11, 2021

we get this dependency from two paths:

  • github.com/docker/buildx => github.com/moby/buildkit => github.com/moby/term => github.com/Azure/go-ansiterm
  • github.com/cnabio/cnab-to-oci => github.com/Azure/go-ansiterm

@thaJeztah
Copy link
Member Author

Yeah, I don't think it needs to reverted (unless we plan to ship Windows ARM binaries), but we should look at fixing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants