This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Allow unspecified protocol on exposed port in kube backend #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Irwin <[email protected]> The Compose spec doesn't provide a default value, but the code was defaulting to TCP in the service protocol, just not in the name. If no protocol was specified, it would cause an invalid service name (eg, "80-")
mat007
approved these changes
Jul 26, 2021
Contributor
mat007
left a comment
mat007
left a comment
There was a problem hiding this comment.
Makes sense, thanks!
@aiordache does that look good to you?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Compose spec doesn't provide a default value, but the code
was defaulting to TCP in the service protocol, just not in the
name. If no protocol was specified, it would cause an invalid
service name (eg, "80-")
What I did
I updated the service name to use the same
toProtocolfunction to remove the option for an invalid service name.