This repository was archived by the owner on Nov 27, 2023. It is now read-only.
allow for 0 scale/replicas #1935
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
pinging @ndeloof @lorenrh @ulyssessouza @mat007 just because I see yous reviewed some other PRs recently. Is there anything I can do to make this easier to review? |
ndeloof
suggested changes
Jul 23, 2021
Collaborator
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
LGTM with a explicit check on expected scale==0 to avoid silently ignore a potential error
| // updateProject updates project after service converged, so dependent services relying on `service:xx` can refer to actual containers. | ||
| func (c *convergence) updateProject(project *types.Project, service string) { | ||
| containers := c.getObservedState(service) | ||
| if len(containers) == 0 { |
Signed-off-by: JD Lloret <[email protected]>
ndeloof
approved these changes
Jul 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add check for 0 length containers list, and remove explicit error return for no running services (this is expected).
I'm not familiar enough with the internals of this program to know what far-reaching consequences changing
updateProjectandstartServicein this way will have, but I hope the automated tests in CI will catch anything untoward.Related issue
fixes #1909
(not mandatory) A picture of a cute animal, if possible in relation with what you did
