This repository was archived by the owner on Nov 27, 2023. It is now read-only.
include volume_from as a source for implicit dependencies #2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
volume_from_deps
branch
from
779ec29 to
a92f15d
Compare
pkg/compose/create.go
Outdated
Comment on lines
183
to
185
| for _, s := range deps { | ||
| if _, ok := service.DependsOn[s.Name]; !ok { | ||
| service.DependsOn[s.Name] = types.ServiceDependency{ |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| for _, s := range deps { | |
| if _, ok := service.DependsOn[s.Name]; !ok { | |
| service.DependsOn[s.Name] = types.ServiceDependency{ | |
| for _, d := range deps { | |
| if _, ok := service.DependsOn[d.Name]; !ok { | |
| service.DependsOn[d.Name] = types.ServiceDependency{ |
ndeloof
force-pushed
the
volume_from_deps
branch
from
a92f15d to
66b7cf3
Compare
lorenrh
approved these changes
Aug 25, 2021
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
volume_from_deps
branch
from
66b7cf3 to
4b808e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Consider
volume_fromas an implicit definition for service dependenciesRelated issue
close https://github.com/docker/compose-cli/issues/2035