This repository was archived by the owner on Nov 27, 2023. It is now read-only.
build metrics compatibility for next 22.06 #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
build-metrics-futureproof
branch
from
58700a7 to
5b8f702
Compare
mat007
approved these changes
May 23, 2022
crazy-max
force-pushed
the
build-metrics-futureproof
branch
from
5b8f702 to
42f0e08
Compare
Contributor
Author
|
converting to draft for now. after discussing with @tonistiigi, calling |
crazy-max
force-pushed
the
build-metrics-futureproof
branch
from
42f0e08 to
1667e0b
Compare
rumpl
reviewed
Jun 27, 2022
Merged
crazy-max
force-pushed
the
build-metrics-futureproof
branch
from
1667e0b to
37d3c02
Compare
Contributor
Author
|
Switch from shelling out to retrieve docker cli version by using the |
crazy-max
force-pushed
the
build-metrics-futureproof
branch
4 times, most recently
from
8182ed4 to
69495d8
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
build-metrics-futureproof
branch
from
69495d8 to
668b262
Compare
nicksieger
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/cli#3314 and #2104
Ensures build metrics are future proof for the next Docker major release.
To detect if buildx will be used while typing
docker build ..., we need to check the current docker cli version. I don't think there is another simple way, besides creating an infamous custom dimension in Looker. 😅cc @tonistiigi @chris-crone @gtardif @mat007
Signed-off-by: CrazyMax [email protected]