Provide shaded artifact

[KostyaSha]

Like https://github.com/spotify/docker-client should also help simplify https://github.com/jenkinsci/docker-plugin structure.

[marcuslinke]

@KostyaSha I've just adopted the mentioned configuration of the shading plugin. Could you test with https://github.com/docker-java/docker-java/tree/issue-340 please?

[KostyaSha]

Thanks! Will try as soon as i get free time.

[KostyaSha]

Cross-linking the same issue spotify/docker-client#272

[KostyaSha]

Playing locally with full shading and seems org.glassfish can't work after shading
yad.dockerjava.org.glassfish.jersey.internal.RuntimeDelegateImpl could not be instantiated: java.lang.IllegalStateException: No generator was provided and there is no default generator registered

[marcuslinke]

Hmm. Maybe something like this is missing?

<relocation>
   <pattern>org.glassfish.jersey</pattern>
   <shadedPattern>com.github.dockerjava.shaded.org.glassfish.jersey</shadedPattern>
</relocation>

[KostyaSha]

Exactly this causes errors because jersey code somewhere depend on original class names and after classes relocation fails. Btw i have all required configuration for shading but having shaded artifact in upstream doesn't make sense when you want use 2 different docker-java versions in your project. In this case you should shade yourself with custom prefixes. Nevertheless shaded artifact and maven configuration can be upstream example for custom shaders.
But there are nuances in shading and attaching artifacts into build, i played locally with different variants and still have no final configuration. In single-module version with depenedencyReduced pom, project that depends on this artifact gets full pom that brings wrong dependencies. So i continue playing locally with 'shadedArtifactAttached falseandshadedArtifactName`.

[KostyaSha]

@marcuslinke i created multi-module test repo for checking shading. Could you help with this error KostyaSha/docker-java-shade#1 ?

[KostyaSha]

Ok, summary is that i solved full shading. @aheritier said that will try ping maven-shade-plugin maintainers, then we will be able resolve #432 and finally close this issue.

[marcuslinke]

Related: https://issues.apache.org/jira/browse/MSHADE-182

[marcuslinke]

Waiting for version 3.0.0 of maven-shade-plugin