-
Notifications
You must be signed in to change notification settings - Fork 8k
engine: consolidate network drivers documentation #23731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: David Karlsson <[email protected]>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robmry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - comments can be suggestions for follow-up.
| 8. Clean up: | ||
|
|
||
| ```console | ||
| $ docker container stop alpine1 alpine2 | ||
| $ docker container rm alpine1 alpine2 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add a "docker ps -a" between the stop and rm, to note that stopped containers lose their IP address etc?
| 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1 | ||
| link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 | ||
| inet 127.0.0.1/8 scope host lo | ||
| valid_lft forever preferred_lft forever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could update this to include the ::1 on lo (which will now be there unless IPv6 is disabled on the host, or by sysctl-ing the container).
Description
Conslidates the documentation on network drivers, which for some drivers is
currently split up into two separate pages:
This PR removes the separate tutorials page and incorporates the relevant
content into the main page.