Skip to content

fix: the uncaught typeerror when el is null #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2020
Merged

fix: the uncaught typeerror when el is null #1308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b1fc3
fix: the uncaught typeerror when el is null
sy-records Jul 26, 2020
bf20ea1
Merge branch 'develop' into fix-1154
sy-records Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/router/history/hash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class HashHistory extends History {
on('click', e => {
const el = e.target.tagName === 'A' ? e.target : e.target.parentNode;

if (el.tagName === 'A' && !/_blank/.test(el.target)) {
if (el && el.tagName === 'A' && !/_blank/.test(el.target)) {
navigating = true;
}
});
Expand Down