Skip to content

Conversation

@bashkirtsevich
Copy link
Contributor

Update navigation feature. Scroll page to top, when user click on nav node (lvl 1 header in navigator).

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@bashkirtsevich
Copy link
Contributor Author

Also may be should add scrollTo(null) here?

@timaschew
Copy link
Member

Please run these commands to trigger netlify deployment for this Pull Request:

git commit --amend --no-edit
git push --force

@solymosi
Copy link
Contributor

solymosi commented Apr 13, 2019

I think setting auto2top to true achieves the same effect as this PR. As a result, this PR would essentially force-enable auto2top for everyone, nullifying the browser's auto scroll-restoration behavior when going back and forward in history.

I've submitted an alternative proposal in #744

@timaschew
Copy link
Member

Closing in favor of #744
I've started a discussion regarding whether auto2top: false make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants