Rename AsEventListener to AsDoctrineListener #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
listener-attr
branch
from
e4fc3f9 to
4a0423a
Compare
ostrolucky
approved these changes
Dec 8, 2022
stof
approved these changes
Dec 8, 2022
dmaicher
approved these changes
Dec 8, 2022
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 27, 2024
…as added (jdreesen) This PR was merged into the 6.4 branch. Discussion ---------- [Doctrine] Fix the version in which AsDoctrineListener was added See: doctrine/DoctrineBundle#1561 & doctrine/DoctrineBundle#1592 Commits ------- dcb42cb Fix the version in which AsDoctrineListener was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1583, I think introducing at attribute with the same name as the one used in Symfony is going to create needless confusion.
I therefor propose to rename the attribute to
AsDoctrineListener.