Skip to content

Conversation

@timcassell
Copy link
Collaborator

Found while trying to run manual tests. Introduced in #2423

@timcassell timcassell added the bug label Dec 22, 2024
@timcassell timcassell force-pushed the fix-long-path branch 5 times, most recently from 44e19d3 to 00adc98 Compare December 22, 2024 09:49
@timcassell timcassell requested a review from AndreyAkinshin May 21, 2025 22:50
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would be nice to extract 36 to a constant to avoid duplication. The rest is great, thanks!

@timcassell timcassell merged commit 56610bc into master May 22, 2025
19 of 20 checks passed
@timcassell timcassell deleted the fix-long-path branch May 22, 2025 10:04
@timcassell timcassell added this to the v0.15.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants