Adding some additional fixups allow LLVMSharp to be regenerated #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
commented
Apr 26, 2019
|
|
||
| case CXCursorKind.CXCursor_CompoundStmt: | ||
| { | ||
| return CXChildVisitResult.CXChildVisit_Continue; |
Member
Author
There was a problem hiding this comment.
It would probably be nice to allow traversing this eventually, but that goes a bit out of scope as compared to just generating bindings (this crops up for methods who's body exist in the header file).
mjsabby
approved these changes
Apr 26, 2019
Member
Author
|
Regenerated LLVMSharp here: dotnet/LLVMSharp#93. There are still a few quirks to workout... I'll be looking at those later this evening. |
tannergooding
commented
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the binding generator over LLVMSharp after #34 was merged. Found a few places that weren't covered yet.