More improvements to the P/Invoke Binding Generator #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
commented
Apr 29, 2019
| using System; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| public partial struct CXTargetInfoImpl |
Member
Author
There was a problem hiding this comment.
The changes here are a side effect of doing two passes. I validated manually there was zero diff without that commit.
tannergooding
commented
Apr 29, 2019
| using System.Diagnostics; | ||
| using ClangSharp; | ||
|
|
||
| namespace ClangSharpPInvokeGenerator |
Member
Author
There was a problem hiding this comment.
These all got moved into CursorWriter so they could depend on the ConfigurationOptions
tannergooding
commented
Apr 29, 2019
| "commandName": "Project", | ||
| "commandLineArgs": "--m clang --p clang_ --namespace ClangSharp --output ../../../../ClangSharp/Generated.cs --libraryPath $(LibClangName) --include $(LLVMIncludePath) --file $(LLVMIncludePath)/clang-c/Index.h --file $(LLVMIncludePath)/clang-c/CXString.h --file $(LLVMIncludePath)/clang-c/Documentation.h --file $(LLVMIncludePath)/clang-c/CXErrorCode.h --file $(LLVMIncludePath)/clang-c/BuildSystem.h --file $(LLVMIncludePath)/clang-c/CXCompilationDatabase.h --excludeFunctions clang_index_getClientEntity,clang_index_setClientEntity,clang_createTranslationUnitFromSourceFile,clang_parseTranslationUnit,clang_parseTranslationUnit2,clang_parseTranslationUnit2FullArgv,clang_reparseTranslationUnit,clang_codeCompleteAt,clang_indexSourceFile,clang_indexSourceFileFullArgv,clang_disposeSourceRangeList,clang_annotateTokens,clang_annotateTokens,clang_disposeTokens,clang_tokenize,clang_disposeStringSet,clang_getCompletionParent,clang_disposeCXPlatformAvailability,clang_getCursorPlatformAvailability", | ||
| "environmentVariables": { | ||
| "LLVMIncludePath": "C:\\Program Files\\LLVM\\include" |
Member
Author
There was a problem hiding this comment.
These weren't needed as the actual setting was coming from the csproj file, which is probably better.
mjsabby
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some additional cleanup of the P/Invoke Binding Generator and allowed dotnet/LLVMSharp#93 to be regenerated and fixed to work end to end.
The primary changes are: