Skip to content

Conversation

@tannergooding
Copy link
Member

This is the same infrastructure setup that was done for ClangSharp in dotnet/ClangSharp#60, but it additionally removes the now unneeded custom libLLVM support.

@tannergooding
Copy link
Member Author

This also removes the now outdated/checked in copy of ClangSharpPInvokeGenerator (which is the bulk of the diff).

@tannergooding
Copy link
Member Author

Seems I broke travis, will investigate shortly.

@tannergooding
Copy link
Member Author

Got most things resolved (namely forgetting to mark shell scripts as executable), but libLLVM still can't be found when running tests. It's passing locally on a clean machine (both Windows and Linux), so I'm still trying things out...

@tannergooding
Copy link
Member Author

It might be because the CI is running on "trusty" and I upgraded the PackageReference from 5.0.1 to 7.0.1...

@tannergooding tannergooding force-pushed the cleanup branch 3 times, most recently from d2cd707 to 4382a26 Compare June 1, 2019 17:20
@tannergooding
Copy link
Member Author

Ok. Some dependency of libLLVM 7.0.1 is missing from the Travis CI machines. I tested up to bionic, and they all failed.

That, unfortunately, means that the CI tests are validating much older LLVM bits.

@tannergooding
Copy link
Member Author

I've squashed the additional changes into a single commit to make reviewing them easier. I've also attempted to keep LLVMSharp targeting 7.0.1 (so the nuget package is more correct) while keeping LLVMSharp.UnitTests targeting 5.0.1 (so tests in CI can pass).

@mjsabby
Copy link
Contributor

mjsabby commented Jun 1, 2019

Thanks. We should talk offline about dnceng vs getting our own instance. And then retiring this Travis CI system.

@mjsabby
Copy link
Contributor

mjsabby commented Jun 1, 2019

By talk I mean ... nudging the relevant folks more :)

@tannergooding tannergooding merged commit 19a14a7 into dotnet:master Jun 1, 2019
@tannergooding tannergooding deleted the cleanup branch June 9, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants