Skip to content

Conversation

@AArnott
Copy link
Collaborator

@AArnott AArnott commented Sep 18, 2025

No description provided.

@AArnott AArnott added this to the v3.8 milestone Sep 18, 2025
@AArnott AArnott linked an issue Sep 18, 2025 that may be closed by this pull request
@AArnott
Copy link
Collaborator Author

AArnott commented Sep 18, 2025

@timheuer can you download the build artifacts and give this a try before I merge it?

@timheuer
Copy link
Member

timheuer commented Sep 18, 2025

Something definitely not working still...here's what I'm seeing (reflected in this run: https://github.com/timheuer/SampleDotnetMcpServer/actions/runs/17834480394)

pack is successful, but the resulting nuget package does NOT include the stamped JSON correctly (the artifact is in the run). I added a debug step and don't even see the nb.gv\server.json file in the obj directory at all. HOWEVER on local windows runs I do see that being output. Linux thing?

UPDATE: using either a linux/windows runner on GHA I don't see the obj resource there at all. When running locally I do...no idea.

Okay, a .NET SDK target was preventing the logic from working correctly and it is required that .NET 10 SDK is used for the new PackageType. After resolving that, the flow works, I can confirm this change works as expected now!

@AArnott
Copy link
Collaborator Author

AArnott commented Sep 18, 2025

Okay, a .NET SDK target was preventing the logic from working correctly and it is required that .NET 10 SDK is used for the new PackageType. After resolving that, the flow works

@timheuer Which target was it? Is it something NB.GV needs to accommodate or was it unique to your situation?

@timheuer
Copy link
Member

Which target was it?

I think I deleted that binlog -- it was basically seeing the McpServer package type as invalid and re-classifying it only as DotnetTool and thus the target didn't run. It makes sense to require NET10 here though as the underlying package support in the runtime to execute the MCP server from dnx requires NET10 anyway. I'm fine with that requirement...was just a miss on my part and locally I had net10 which is why 'everything working fine' was confusing me.

@AArnott
Copy link
Collaborator Author

AArnott commented Sep 18, 2025

Great. Thank you for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for stamping version on server.json for MCP servers

3 participants