Vulkan: Add MoltenVK and portability to MacOS library names #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoltenVK is (obviously) above portability, and while gfx-rs/portability is dead development wise, there are likely people who want to package it with their app and use it for whatever reason, so lets shove it at the end of the libnames to check, since we are able to, and shouldnt hurt anything
|
Can we not add libportability, I’d rather just only have MoltenVK and have it be for legacy reasons. Really we should be using the loader on all platforms but we (I) backed ourselves into a corner by Not Doing That. |
Perksey
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues, Discord discussions, or proposals
#1197 (comment)
Further Comments
MoltenVK is (obviously) above portability, and while gfx-rs/portability is dead development wise, there are maybe people who want to package it with their app and use it for whatever reason, or end users who want to use it with some app, so lets shove it at the end of the libnames to check, since we are able to, and it shouldnt hurt anything, given the loader and Molten VK are prioritized