Build fails with error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned

[frankbuckley]

Following (I think) the guidelines for building Microsoft.Data.SqlClient, when I execute msbuild I get:

Build FAILED.

"V:\dev\frankbuckley\SqlClient\build.proj" (Restore target) (1) ->
"V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\ref\Microsoft.Data.SqlClient.csproj" (restore target) (4) ->
(Restore target) ->
  V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\ref\Microsoft.Data.SqlClient.csproj : error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
  V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\ref\Microsoft.Data.SqlClient.csproj : error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.


"V:\dev\frankbuckley\SqlClient\build.proj" (Restore target) (1) ->
"V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\src\Microsoft.Data.SqlClient.csproj" (restore target) (5) ->
  V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\src\Microsoft.Data.SqlClient.csproj : error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
  V:\dev\frankbuckley\SqlClient\src\Microsoft.Data.SqlClient\netcore\src\Microsoft.Data.SqlClient.csproj : error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.

    0 Warning(s)
    4 Error(s)

Have I missed something?

[paulmedynski]

Hi @frankbuckley - I'm not seeing this error when I build:

PS C:\Users\paulmedynski\dev\SqlClient\main> msbuild

...

Done Building Project "C:\Users\paulmedynski\dev\SqlClient\main\build.proj" (default targets).

Build succeeded.

"C:\Users\paulmedynski\dev\SqlClient\main\build.proj" (default target) (1) ->
"C:\Users\paulmedynski\dev\SqlClient\main\src\Microsoft.Data.SqlClient\netfx\src\Microsoft.Data.SqlClient.cspro
j" (default target) (7:7) ->
(ResolveCodeAnalysisRuleSet target) ->
  C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Current\Bin\amd64\Microsoft.CSharp.Cur
rentVersion.targets(130,9): warning MSB3884: Could not find rule set file "MinimumRecommendedRules.ruleset". [C
:\Users\paulmedynski\dev\SqlClient\main\src\Microsoft.Data.SqlClient\netfx\src\Microsoft.Data.SqlClient.csproj]

    1 Warning(s)
    0 Error(s)

Time Elapsed 00:02:17.00

(Ignore the warning)

Are you still seeing it with the latest repo pulled? If so, can you indicate what command you're running to initiate the build?

[edwardneal]

This is a breaking change when building with the .NET 10 SDK, documented here. It's probably showing up when the .NET 10 previews are installed.

Fixing this might have implications when people create issues for vulnerable dependencies (if that dependency is part of .NET.)

[Frulfump]

Yeah super important to mention which version of the SDK(MsBuild) that's being used when reporting or trying to confirm issues (Why isn't dotnet build being used instead since its the modern command?). I mentioned the System.Text.Json dependency here #3553 (comment)

You should probably build the client with preview SDKs to find issues early as .NET 10 releases in just 3 months with the RC expected next month.

[frankbuckley]

This is a breaking change when building with the .NET 10 SDK, documented here. It's probably showing up when the .NET 10 previews are installed.

Fixing this might have implications when people create issues for vulnerable dependencies (if that dependency is part of .NET.)

Yes - thank you - that was the cause - I had a preview SDK installed.

Adding a global.json file to specify the SDK fixes the issue:

{
  "sdk": {
    "version": "9.0.300",
    "rollForward": "latestFeature"
  }
}

[paulmedynski]

I've opened #3576 to handle any issues with the .NET 10 SDK.