Skip to content

Fix potential security vulnerabilities. #1612

@AraHaan

Description

@AraHaan

Describe the bug

In my pr #1536 I have discovered that a few obsolete apis are used which in .NET Core is ignored which can result in some security vulnerabilities.

Of which include:

  • the usage of WebClient, WebRequest, etc that were obsoleted for HttpClient.
  • CER
  • CAS

To reproduce

Currently the PR #1536 shows that to reproduce it, all you have to do is add net5.0 or net6.0 as shown in the PR to the SqlClient projects and then hit compile to get compile errors related to the deprecated apis and it saying not to use them as they can pose as an security issue.

Expected behavior

For the obsoleted apis to not be used as per Microsoft's recommendations from the documentations to each compile error that is the result from each of their usage.

Further technical details

Microsoft.Data.SqlClient version: version from repo in #1536
.NET target: .NET 6 (6.0.5)
SQL Server version: SQL Server 2019
Operating system: Windows 11

Additional context

I have made temporary changes to these in #1536, however I would like to split them out of that PR so they do not get blocked until .NET 6 is added to the CI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions