Skip to content

Conversation

@cheenamalhotra
Copy link
Member

Introduces below changes:

Microsoft.SqlServer.Server (new NuGet Package)

  • Provides Microsoft.SqlServer.Server (9 types) – targeting .NET Standard 2.0

    • Microsoft.Sqlserver.Server.SqlFacetAttribute
    • Microsoft.Sqlserver.Server.SqlFunctionAttribute
    • Microsoft.SqlServer.Server.SqlMethodAttribute
    • Microsoft.Sqlserver.Server.SqlUserDefinedAggregateAttribute
    • Microsoft.Sqlserver.Server.SqlUserDefinedTypeAttribute
    • Microsoft.SqlServer.Server.IBinarySerialize
    • Microsoft.SqlServer.Server.Format
    • Microsoft.SqlServer.Server.DataAccessKind
    • Microsoft.SqlServer.Server.SystemDataAccessKind
  • Types forwarded to System.Data - for .NET Framework 4.6.1+

To support adaptability for Microsoft.SqlServer.Types in .NET Core support

Changes in Microsoft.Data.SqlClient (.NET Framework)

  • Depends on System.Data > Microsoft.SqlServer.Server namespace for selected 9 types. All references updated.
  • 9 types from Microsoft.Data.SqlClient.Server (old namespace) are left as-is [to be declared as deprecated]
    • WIP Decision - To remove them completely or let them stay.

Changes in Microsoft.Data.SqlClient (.NET Core 2.1+ & .NET Standard 2.0+)

  • Depends on Microsoft.SqlServer.Server v1.0.0-dev.21174.6 (new NuGet) for selected 9 types. All references updated.
  • 9 types from Microsoft.Data.SqlClient.Server (old namespace) are left as-is [to be declared as deprecated].
    • WIP Decision - To remove them completely or let them stay.

Test: SqlServer Types Insert And Read

  • Broken test case added for below CLR Microsoft.SqlServer.Types that is now fixed with this PR in .NET Framework:
    • SqlHierarchyId
    • SqlGeometry
    • SqlGeography

@cheenamalhotra cheenamalhotra added the Public API 🆕 Issues/PRs that introduce new APIs to the driver. label Jul 5, 2021
…-server + Support NetFx 4.6 for MS.Server package

# Conflicts:
#	src/Microsoft.Data.SqlClient.sln
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
#	tools/props/Versions.props
@DavoudEshtehari
Copy link
Contributor

Regarding the plan changes, work continues on a fresh PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Public API 🆕 Issues/PRs that introduce new APIs to the driver.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants