Combine: Move SqlEnvChange to shared and sync usage #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is green because nothing ran? This is a new sort of broken. |
The CI now runs all under one job "CI-SqlClient". It seems to be pretty stable so far. |
|
Ok. Well everything is green so it can be merged immediately then 😁 |
johnnypham
approved these changes
Mar 4, 2022
DavoudEshtehari
added
the
Code Health 💊
DavoudEshtehari
requested review from
DavoudEshtehari,
JRahnama and
Kaur-Parminder
David-Engel
approved these changes
May 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1525 +/- ##
==========================================
+ Coverage 64.31% 71.34% +7.02%
==========================================
Files 327 296 -31
Lines 64594 62133 -2461
==========================================
+ Hits 41545 44328 +2783
+ Misses 23049 17805 -5244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
DavoudEshtehari
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-work of #1200 which was closed because it had been open so long that it wasn't possible to rebase it. Can you please given this some attention, I don't want to have to wait 6 months and do it a third time.