Fix forced on SNI log entries #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
approved these changes
Apr 14, 2022
johnnypham
approved these changes
Apr 26, 2022
Kaur-Parminder
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
dotnet-traceof other method to collect event traces the managed SNI implementation uses a different disposable scope object to other parts of the library, it usesTrySNIEventScopeinstead ofTryEventScope. While investigating #1543 I saw that that there are two issues withTrySNIEventScope1) that is is not conditionally checked so it always generates strings and longs as well as spending time formatting 2) the create message contains only the name of the class not the member name or the scopeid meaning that the open and close scopes cannot be correleated.This PR changes these using the existing patterns found in
TryEventScope. It also changes to use string interpolation because when we get a .net 6+ build these will be optimized by the compiler using interpolated string builder.It changes the trace output from:
to:
