Skip to content

Conversation

DavoudEshtehari
Copy link
Contributor

fixes #1650.

@DavoudEshtehari DavoudEshtehari added 🐛 Bug! Area\Netcore Issues that apply only to .NET runtime or the 'netcore' project folder. labels Jun 21, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0 milestone Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1654 (87b2970) into main (d8fcede) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   71.41%   71.42%           
=======================================
  Files         291      291           
  Lines       61241    61241           
=======================================
+ Hits        43738    43742    +4     
+ Misses      17503    17499    -4     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.97% <ø> (ø)
netfx 69.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 71.42% <0.00%> (-3.58%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.48% <0.00%> (-0.59%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.27% <0.00%> (-0.35%) ⬇️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.97% <0.00%> (-0.02%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.87% <0.00%> (ø)
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.37% <0.00%> (+0.09%) ⬆️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 72.57% <0.00%> (+0.38%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fcede...87b2970. Read the comment docs.

@DavoudEshtehari DavoudEshtehari marked this pull request as ready for review June 21, 2022 16:29
@DavoudEshtehari DavoudEshtehari merged commit f1172a6 into dotnet:main Jun 22, 2022
@ErikEJ
Copy link
Contributor

ErikEJ commented Jun 22, 2022

Any plans for a quick preview 4?

@DavoudEshtehari
Copy link
Contributor Author

The next version will be GA v5.0.
@David-Engel can specify the estimated release date.

@David-Engel
Copy link
Contributor

5.0 GA is targeting July 15, barring any more blocking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Netcore Issues that apply only to .NET runtime or the 'netcore' project folder.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.0.0-preview3.22168.1 error

4 participants