Addressing HostNameInCertificate changes in native SNI #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcheunglci
changed the title
lcheunglci
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
+ Coverage 62.29% 70.93% +8.63%
==========================================
Files 293 293
Lines 61382 61383 +1
==========================================
+ Hits 38237 43540 +5303
+ Misses 23145 17843 -5302
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DavoudEshtehari
added
the
Area\Netfx
David-Engel
approved these changes
Jul 26, 2022
…github.com/lcheunglci/SqlClient into TDS8-Add-ServerCertFile-InAuthProviderInfo
DavoudEshtehari
requested review from
DavoudEshtehari,
JRahnama and
Kaur-Parminder
|
FYI, after releasing the native SNI, the pipeline should be triggered with the new SNI package for this change before having merged it. |
David-Engel
approved these changes
Aug 3, 2022
DavoudEshtehari
approved these changes
Aug 4, 2022
DavoudEshtehari
added
Area\Native SNI
Kaur-Parminder
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some of the latest changes from SNI, the struct AuthProviderInfo includes a new field, i.e.
serverCertFileName, so this change is to make sure it is compatible.