Skip to content

Fix th-TH culture info issue on Managed SNI #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 28, 2023
Merged

Fix th-TH culture info issue on Managed SNI #2066

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5c505a1
Add SqlConnectionEncryptOptionConverter class which is used to conver…
arellegue Jun 8, 2023
9b9af7e
Merge branch 'main' of https://github.com/arellegue/SqlClient
arellegue Jun 8, 2023
7f09dd9
Add StringComparison.OrdinalIgnoreCase in InferNamedPipesInformation …
arellegue Jun 15, 2023
713b215
Added unit test using th-TH culture info.
arellegue Jun 16, 2023
1bc7d7d
Revert "Add SqlConnectionEncryptOptionConverter class which is used t…
arellegue Jun 16, 2023
89340b6
Enclose in try catch finally the setting of th-TH culture in unit test.
arellegue Jun 16, 2023
d510fec
Raname currentCulture to saveCulture.
arellegue Jun 16, 2023
a67795c
Changed StringComparison option from OrdinalIgnoreCase to Ordinal.
arellegue Jun 19, 2023
69736aa
Move the th-TH unit test to Manual test project.
arellegue Jun 20, 2023
a45a47c
Removed blank line.
arellegue Jun 20, 2023
650cc6c
Move ConnectionTestWithCutltureTH back to SqlConnectionBasicTests.
arellegue Jun 21, 2023
0495369
Apply suggestions from code review
JRahnama Jun 23, 2023
26c7ead
Change comment to restore saved culture.
arellegue Jun 27, 2023
7e3a257
Merge branch 'main' into Issue_1579_th-TH_CultureInfo
arellegue Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Data;
using System.Data.Common;
using System.Globalization;
using System.Reflection;
using System.Security;
using System.Threading;
Expand Down Expand Up @@ -250,6 +251,32 @@ public void ConnectionTestValidCredentialCombination()
Assert.Equal(sqlCredential, conn.Credential);
}

[Fact]
public void ConnectionTestWithCultureTH()
{
CultureInfo savedCulture = Thread.CurrentThread.CurrentCulture;
CultureInfo savedUICulture = Thread.CurrentThread.CurrentUICulture;

try
{
Thread.CurrentThread.CurrentCulture = new CultureInfo("th-TH");
Thread.CurrentThread.CurrentUICulture = new CultureInfo("th-TH");

using TestTdsServer server = TestTdsServer.StartTestServer();
using SqlConnection connection = new SqlConnection(server.ConnectionString);
connection.Open();
Assert.Equal(ConnectionState.Open, connection.State);
}
finally
{
// Restore saved cultures if necessary
if (Thread.CurrentThread.CurrentCulture != savedCulture)
Thread.CurrentThread.CurrentCulture = savedCulture;
if (Thread.CurrentThread.CurrentUICulture != savedUICulture)
Thread.CurrentThread.CurrentUICulture = savedUICulture;
}
}

[Fact]
public void ConnectionTestAccessTokenCallbackCombinations()
{
Expand Down