Expose SSPI context provider as public

[twsouthwick]

This change:

• Adds a property to SqlConnection to allow setting a provider
• Plumbs that property into the TdsParser so that it can be used if set

Fixes #2253

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.06%. Comparing base (63443f4) to head (ee6c4cf).

❗ There is a different number of reports uploaded between BASE (63443f4) and HEAD (ee6c4cf). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (63443f4)	HEAD (ee6c4cf)
addons	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2494       +/-   ##
===========================================
- Coverage   69.90%   59.06%   -10.84%     
===========================================
  Files         276      270        -6     
  Lines       62414    62098      -316     
===========================================
- Hits        43629    36677     -6952     
- Misses      18785    25421     +6636     

Flag	Coverage Δ
addons	?
netcore	61.71% <ø> (-11.13%)	⬇️
netfx	62.71% <ø> (-6.91%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[benrr101]

Overall, really like the goal and implementation. Most of my comments are style related, since I'm sure my colleagues have tackled the bigger questions.

[paulmedynski]

Made an initial pass, and came up with some questions/comments.

[paulmedynski]

Factory vs instance in the netfx code, and a few questions about docs.

[nhart12]

Latest package still works for our use-case

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[twsouthwick]

@paulmedynski @mdaigle the two failures look to be test failures with sql server setup. otherwise it's ready again

[twsouthwick]

@mdaigle @paulmedynski any updates on timing here? Are we still waiting for a security review?

[mdaigle]

@twsouthwick yes, we still need to set up a security review. We had originally planned on doing that for the 6.1 release but opted to avoid security sensitive changes. I'm hoping I'll have a chance soon to update out threat model diagrams for this feature and then schedule a feature specific review.

[twsouthwick]

@mdaigle I've created a separate PR to make the non-public changes so that future merge conflicts are minimal: #3511

[paulmedynski]

How hard would it be to implement the positive test Malcolm suggests?

[paulmedynski]

We should be able to use the test TDS Server for this. Implement a custom SSPI provider in the driver that just sends "Foo", have the TDS Server check for "Foo" and send back "Bar", and then have the custom provider check for "Bar" and complete the Open().

[Copilot]

Pull Request Overview

This PR exposes the SSPI context provider as a public API to allow custom authentication implementations. The change makes the SspiContextProvider class and related types public so that developers can implement custom SSPI authentication logic.

• Converts internal SSPI-related classes to public APIs with proper documentation
• Adds a public property to SqlConnection for setting custom SSPI context providers
• Includes comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
SspiContextProvider.cs	Made class public and added XML documentation includes
SspiAuthenticationParameters.cs	Made class public with documentation includes for all properties
SqlConnection.cs (netfx & netcore)	Changed SspiContextProvider property from internal to public
Microsoft.Data.SqlClient.cs (ref files)	Added public API definitions for both netfx and netcore
IntegratedAuthenticationTest.cs	Added test for custom SSPI context provider functionality
Microsoft.Data.SqlClient.sln	Added new documentation files to solution
SspiContextProvider.xml	New XML documentation for SspiContextProvider
SspiAuthenticationParameters.xml	New XML documentation for SspiAuthenticationParameters
SqlConnection.xml	Added documentation for SspiContextProvider property

[Copilot]

Corrected spelling of 'Micorosft' to 'Microsoft'.

Suggested change

	An <see cref="T:Micorosft.Data.SqlClient.SspiContextProvider" /> instance.
	An <see cref="T:Microsoft.Data.SqlClient.SspiContextProvider" /> instance.

[benrr101]

@twsouthwick I took the liberty of resolving the merge conflict. I'd like to try and get this in by end of week, but I get that's gonna be tight. nevermind we'll get it in ... someday

[mdaigle]

@benrr101 we still need a threat model review before we can take this change