Skip to content

Remove SQL 2000 client-side debugging support #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Remove SQL 2000 client-side debugging support #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66dfa0d
Remove SQL debugging client-side support
edwardneal Nov 6, 2024
1e1bc3d
Merge from upstream
edwardneal Nov 13, 2024
3aeec6f
Remove migrated AdvApi32 and Kernel32 PInvokes.
edwardneal Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2304,13 +2304,6 @@ private static void ChangePassword(string connectionString, SqlConnectionString
SqlConnectionFactory.SingletonInstance.ClearPool(key);
}

//
// SQL DEBUGGING SUPPORT
//

// this only happens once per connection
// SxS: using named file mapping APIs

internal Task<T> RegisterForConnectionCloseNotification<T>(Task<T> outerTask, object value, int tag)
{
// Connection exists, schedule removal, will be added to ref collection after calling ValidateAndReconnect
Expand Down
3 changes: 0 additions & 3 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@
</ItemGroup>
<!-- Contains common items shared between NetFx and NetCore -->
<ItemGroup>
<Compile Include="$(CommonSourceRoot)Interop\Windows\AdvApi32\AdvApi32.netfx.cs">
<Link>Interop\AdvApi32\AdvApi32.netfx.cs</Link>
</Compile>
<Compile Include="$(CommonSourceRoot)Interop\Windows\Kernel32\FileTypes.cs">
<Link>Interop\Kernel32\FileTypes.cs</Link>
</Compile>
Expand Down
3 changes: 0 additions & 3 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5620,9 +5620,6 @@ private SqlDataReader RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavi
optionSettings = GetResetOptionsString(cmdBehavior);
}

// turn debugging on
_activeConnection.CheckSQLDebug();

// execute sp
Debug.Assert(_rpcArrayOf1[0] == rpc);
writeTask = _stateObj.Parser.TdsExecuteRPC(this, _rpcArrayOf1, timeout, inSchema, this.Notification, _stateObj, CommandType.StoredProcedure == CommandType, sync: !asyncWrite);
Expand Down
Loading
Loading