Skip unit tests friend assembly designation on official builds

[mdaigle]

Description

In official builds, when assemblies are signed and strong names are generated, friend assembly designations must specify a public key. Unit tests are only run when using project reference, which doesn't apply to official signing pipeline runs which use package reference for tests, so we can skip the friend assembly designation in official builds.

To repro:

• generate a strong name key pair using sn.exe -k netfxKeypair.snk
• run the build using: $env:CDP_BUILD_TYPE = 'Official'; msbuild -p:AssemblyFileVersion=6.10.25177.2 -t:BuildAllConfigurations -p:GenerateNuget=false -p:SigningKeyPath=C:\Users\mdaigle\SqlClient\netfxKeypair.snk -p:configuration="Release"

Before:

After:

Testing

Existing unit tests should pass when run in project reference mode.

Guidelines

Please review the contribution guidelines before submitting a pull request:

• Contributing
• Code of Conduct
• Best Practices
• Coding Style
• Review Process

[paulmedynski]

One question.

[benrr101]

I'd appreciate a run on ADO before merging this, but it should be fine as-is

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (fc950e8) to head (ba3f865).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #3447       +/-   ##
==========================================
- Coverage   64.55%       0   -64.56%     
==========================================
  Files         281       0      -281     
  Lines       62519       0    -62519     
==========================================
- Hits        40358       0    -40358     
+ Misses      22161       0    -22161     

Flag	Coverage Δ
addons	?
netcore	?
netfx	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.