Cleanup | Centralise AppContext switches #3492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
requested changes
Jul 22, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.cs
Outdated
Show resolved
Hide resolved
mdaigle
requested changes
Jul 22, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Resources/ILLink.Substitutions.Windows.xml
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.cs
Show resolved
Hide resolved
Move string constants and variables together; add a comment to UseManagedNetworking explaining that it can be turned into a constant by ILLink.
These tests no longer directly set the AppContext switches to round or truncate decimals, since these switches are cached when first queried.
|
Thanks both. I've added the review comments, and the failing Could you run CI please? |
mdaigle
approved these changes
Jul 23, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
- Coverage 68.85% 63.86% -5.00%
==========================================
Files 277 270 -7
Lines 62237 61872 -365
==========================================
- Hits 42854 39515 -3339
- Misses 19383 22357 +2974
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We try to centralise all access to SqlClient's AppContext switches via the
LocalAppContextSwitchesclass. There are currently a few cases where we don't do this though:The first port of call is to relocate all of these to the existing LocalAppContextSwitches class. This slightly helps in the merge of SqlConnection.
I've also added an
ILLink.Substitutions.xmlresource to the output. This is a trimming improvement, and is documented here. It allows referencing applications to specify aRuntimeHostConfigurationOptionto set an AppContext switch, which the IL trimmer will reference and remove the entire managed or native SNI. There's a little more work to come on this once trimming is ready.For comparison purposes, this is modelled in part on CsWinRT:
RuntimeHostConfigurationOptionI've used sizoscope to verify that I can use RuntimeHostConfigurationOption, publish an application and see the corresponding SNI's types are removed from the output.
Issues
Partially relates to #1261 and #1942.
Testing
Unit tests pass locally.