QoL | Improve build/debugging experience

[edwardneal]

Description

These are two minor QoL changes which I've had running locally for a little while to make debugging a little easier and to speed up local builds.

1. 10e60ee: there are four test projects containing UDTs which all had an unnecessary dependency on the main SqlClient library. This removes them, so they shouldn't need to be rebuilt when we build SqlClient.
2. 66a67bc: this is fixing some odd behaviour which emerged from Merge | Merge metrics/performance counter methodology #3251. It looks like when the debugger is attached, the event source is always enabled. OnEventCommand is called before the SqlClientEventSource constructor finishes, and by that point the Metrics property is still null. We now handle this case, making sure that if this happens the metrics start in an enabled state.

Issues

None.

Testing

No automated tests cover this, but manual testing confirms that the build process continues to work and that I no longer receive the NullReferenceException when debugging is enabled.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

Lots of errors from the package-based tests:

  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Roslyn\csc.exe /noconfig /unsafe- /checked- /nowarn:1701,1702,1701,1702 /fullpaths /nostdlib+ /errorreport:prompt /warn:8 /define:TRACE;RELEASE;NET;NET8_0;NETCOREAPP;NET5_0_OR_GREATER;NET6_0_OR_GREATER;NET7_0_OR_GREATER;NET8_0_OR_GREATER;NETCOREAPP1_0_OR_GREATER;NETCOREAPP1_1_OR_GREATER;NETCOREAPP2_0_OR_GREATER;NETCOREAPP2_1_OR_GREATER;NETCOREAPP2_2_OR_GREATER;NETCOREAPP3_0_OR_GREATER;NETCOREAPP3_1_OR_GREATER /highentropyva+ /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\Microsoft.CSharp.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\Microsoft.VisualBasic.Core.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\Microsoft.VisualBasic.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\Microsoft.Win32.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\Microsoft.Win32.Registry.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\mscorlib.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\netstandard.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.AppContext.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Buffers.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Collections.Concurrent.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Collections.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Collections.Immutable.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Collections.NonGeneric.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Collections.Specialized.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.Annotations.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.DataAnnotations.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.EventBasedAsync.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ComponentModel.TypeConverter.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Configuration.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Console.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Core.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Data.Common.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Data.DataSetExtensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Data.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.Contracts.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.Debug.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.DiagnosticSource.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.FileVersionInfo.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.Process.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.StackTrace.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.TextWriterTraceListener.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.Tools.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.TraceSource.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Diagnostics.Tracing.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Drawing.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Drawing.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Dynamic.Runtime.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Formats.Asn1.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Formats.Tar.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Globalization.Calendars.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Globalization.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Globalization.Extensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Compression.Brotli.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Compression.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Compression.FileSystem.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Compression.ZipFile.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.FileSystem.AccessControl.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.FileSystem.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.FileSystem.DriveInfo.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.FileSystem.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.FileSystem.Watcher.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.IsolatedStorage.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.MemoryMappedFiles.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Pipes.AccessControl.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.Pipes.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.IO.UnmanagedMemoryStream.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Linq.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Linq.Expressions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Linq.Parallel.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Linq.Queryable.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Memory.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Http.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Http.Json.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.HttpListener.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Mail.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.NameResolution.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.NetworkInformation.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Ping.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Quic.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Requests.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Security.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.ServicePoint.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.Sockets.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.WebClient.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.WebHeaderCollection.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.WebProxy.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.WebSockets.Client.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Net.WebSockets.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Numerics.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Numerics.Vectors.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ObjectModel.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.DispatchProxy.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Emit.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Emit.ILGeneration.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Emit.Lightweight.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Extensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Metadata.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Reflection.TypeExtensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Resources.Reader.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Resources.ResourceManager.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Resources.Writer.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.CompilerServices.Unsafe.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.CompilerServices.VisualC.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Extensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Handles.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.InteropServices.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.InteropServices.JavaScript.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.InteropServices.RuntimeInformation.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Intrinsics.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Loader.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Numerics.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Serialization.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Serialization.Formatters.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Serialization.Json.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Serialization.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Runtime.Serialization.Xml.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.AccessControl.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Claims.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.Algorithms.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.Cng.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.Csp.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.Encoding.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.OpenSsl.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.Primitives.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Cryptography.X509Certificates.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Principal.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.Principal.Windows.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Security.SecureString.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ServiceModel.Web.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ServiceProcess.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.Encoding.CodePages.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.Encoding.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.Encoding.Extensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.Encodings.Web.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.Json.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Text.RegularExpressions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Channels.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Overlapped.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Tasks.Dataflow.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Tasks.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Tasks.Extensions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Tasks.Parallel.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Thread.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.ThreadPool.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Threading.Timer.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Transactions.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Transactions.Local.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.ValueTuple.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Web.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Web.HttpUtility.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Windows.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.Linq.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.ReaderWriter.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.Serialization.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.XDocument.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.XmlDocument.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.XmlSerializer.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.XPath.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\System.Xml.XPath.XDocument.dll /reference:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\ref\net8.0\WindowsBase.dll /debug+ /debug:portable /filealign:512 /optimize+ /pathmap:"D:\a\_work\1\s\src\..\=/_1/,C:\Users\cloudtest\.nuget\packages\=/_2/,C:\Program Files (x86)\Microsoft Visual Studio\Shared\NuGetPackages\=/_3/,D:\a\_work\1\s\=/_/," /out:D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\Address.dll /refout:D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\refint\Address.dll /target:library /warnaserror+ /utf8output /deterministic+ /sourcelink:D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\Address.sourcelink.json /langversion:12.0 /embed:"D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\.NETCoreApp,Version=v8.0.AssemblyAttributes.cs" /embed:D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\Address.AssemblyInfo.cs /analyzerconfig:D:\a\_work\1\s\.editorconfig /analyzerconfig:D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\Address.GeneratedMSBuildEditorConfig.editorconfig /analyzerconfig:C:\hostedtoolcache\windows\sdk\9.0.304\Sdks\Microsoft.NET.Sdk\analyzers\build\config\analysislevel_8_default.globalconfig /analyzer:C:\hostedtoolcache\windows\sdk\9.0.304\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll /analyzer:C:\hostedtoolcache\windows\sdk\9.0.304\Sdks\Microsoft.NET.Sdk\targets\..\analyzers\Microsoft.CodeAnalysis.NetAnalyzers.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/Microsoft.Interop.ComInterfaceGenerator.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/Microsoft.Interop.JavaScript.JSImportGenerator.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/Microsoft.Interop.LibraryImportGenerator.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/Microsoft.Interop.SourceGeneration.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/System.Text.Json.SourceGeneration.dll /analyzer:C:\Users\cloudtest\.nuget\packages\microsoft.netcore.app.ref\8.0.19\analyzers/dotnet/cs/System.Text.RegularExpressions.Generator.dll Address.cs "D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\.NETCoreApp,Version=v8.0.AssemblyAttributes.cs" D:\a\_work\1\s\src\..\artifacts\Package\obj\Release.AnyCPU\Address\net8.0\Address.AssemblyInfo.cs /warnaserror+:NU1605,SYSLIB0011 /warnaserror-:NU1901,NU1902,NU1903,NU1904,NU1905
##[error]src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(12,35): Error CS1069: The type name 'IBinarySerialize' could not be found in the namespace 'Microsoft.SqlServer.Server'. This type has been forwarded to assembly 'System.Data.SqlClient, Version=0.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly.
D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(12,35): error CS1069: The type name 'IBinarySerialize' could not be found in the namespace 'Microsoft.SqlServer.Server'. This type has been forwarded to assembly 'System.Data.SqlClient, Version=0.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly. [D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.csproj::TargetFramework=net8.0]
##[error]src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,2): Error CS0246: The type or namespace name 'SqlUserDefinedTypeAttribute' could not be found (are you missing a using directive or an assembly reference?)
D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,2): error CS0246: The type or namespace name 'SqlUserDefinedTypeAttribute' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.csproj::TargetFramework=net8.0]
##[error]src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,2): Error CS0246: The type or namespace name 'SqlUserDefinedType' could not be found (are you missing a using directive or an assembly reference?)
D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,2): error CS0246: The type or namespace name 'SqlUserDefinedType' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.csproj::TargetFramework=net8.0]
##[error]src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,21): Error CS0103: The name 'Format' does not exist in the current context
D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.cs(11,21): error CS0103: The name 'Format' does not exist in the current context [D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\UdtTest\UDTs\Address\Address.csproj::TargetFramework=net8.0]

Maybe these UDTs need a package reference or two?

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (55cc333) to head (9b7057d).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...oft/Data/SqlClient/Diagnostics/SqlClientMetrics.cs	66.66%	1 Missing ⚠️
...c/Microsoft/Data/SqlClient/SqlClientEventSource.cs	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
+ Coverage   59.44%   64.00%   +4.56%     
==========================================
  Files         268      268              
  Lines       62160    62167       +7     
==========================================
+ Hits        36950    39792    +2842     
+ Misses      25210    22375    -2835     

Flag	Coverage Δ
netcore	67.29% <75.00%> (+5.07%)	⬆️
netfx	63.97% <100.00%> (+0.67%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[edwardneal]

I see what you mean! I've just added the correct handling of ReferenceType=Package to all four projects, so that should be fixed now.

[paulmedynski]

The ReferenceType build property causes me headaches. I think with the move to true unit and integration tests, we won't need it for much longer.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).