Merge | TdsParserStateObject packet handling #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ord has been written to it
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
===========================================
- Coverage 69.61% 59.32% -10.30%
===========================================
Files 276 270 -6
Lines 61714 61431 -283
===========================================
- Hits 42964 36441 -6523
- Misses 18750 24990 +6240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've brought this up-to-date following the TdsParser merge work, can someone run CI please? |
benrr101
added
the
Common Project 🚮
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
approved these changes
Sep 17, 2025
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
Show resolved
Hide resolved
Merged
paulmedynski
approved these changes
Sep 22, 2025
edwardneal
deleted the
merge/tdsparserstateobject-packets-and-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up #3394, merging a number of methods relating to packet handling and some final errata. This is split into multiple commits for ease of review.
I'm moving a few members from TdsParserStateObject to TdsParserStateObjectNative:
SetPacketData is the only truly standout method here. The netfx implementation was structured slightly differently to the netcore implementation, and it also cleared _outBuff after writing a SecureString to the packet. I've added this feature in dcd231e.
This is the final PR prior to the merge of TdsParserStateObject and TdsParserStateObjectNative.
Issues
Relates to #1261.
Testing
Automated tests pass. Can someone run CI please?