Perf: Remove double fetch of domain name #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
approved these changes
Jan 4, 2020
cheenamalhotra
added
the
Performance 📈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling the managed SNI implementation I got distracted by the amount of time it takes to get a connection from the pool. I found this simple change which on windows removes 2 pinvokes and a string allocation by getting the user domain name only once and reusing it.
If we were doing direct invokes instead of using System.Environment wrappers we could do it in 2-3 pinvokes and avoid a couple of string allocations. We would have to be platform specific though and I'd prefer to keep this implementation fully portable if possible. Note that the Environment.UserName and UseDomainName functions do not read environment variables the pinvoke directly so they are compatible with impersonation, any replacement would need to have the same property.