Skip to content

Changed non-generic ArrayList of SqlBulkCopy in NetFx to List #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Changed non-generic ArrayList of SqlBulkCopy in NetFx to List #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5218b98
SqlBulkCopy ArrayList to List in NetFx
JRahnama Mar 5, 2020
30ec082
BulkCopy EventSource
JRahnama Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ internal object this[int index]
sealed internal class Result
{
private _SqlMetaDataSet _metadata;
private ArrayList _rowset;
private List<Row> _rowset;

internal Result(_SqlMetaDataSet metadata)
{
this._metadata = metadata;
this._rowset = new ArrayList();
this._rowset = new List<Row>();
}

internal int Count
Expand Down Expand Up @@ -113,15 +113,15 @@ internal void AddRow(Row row)
//
sealed internal class BulkCopySimpleResultSet
{
private ArrayList _results; // the list of results
private List<Result> _results; // the list of results
private Result resultSet; // the current result
private int[] indexmap; // associates columnids with indexes in the rowarray

// c-tor
//
internal BulkCopySimpleResultSet()
{
_results = new ArrayList();
_results = new List<Result>();
}

// indexer
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ internal int ObjectID
internal byte[] _bShortBytes = null; // scratch buffer to serialize Short values (2 bytes).
internal byte[] _bDecimalBytes = null; // scratch buffer to serialize decimal values (17 bytes).

//
// DO NOT USE THIS BUFFER FOR OTHER THINGS.
// ProcessHeader can be called ANYTIME while doing network reads.
private byte[] _partialHeaderBuffer = new byte[TdsEnums.HEADER_LEN]; // Scratch buffer for ProcessHeader
Expand Down