Skip to content

Enable Diagnostic Source tests with remote executor #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 13, 2020
Merged

Enable Diagnostic Source tests with remote executor #517

merged 12 commits into from
Apr 13, 2020

Conversation

@JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Apr 7, 2020 •
edited
Loading

This PR

  • adds RemoteExecutor to NetCore to enable tests for diagnostic source.

jJRahnama added 5 commits April 7, 2020 12:32
@JRahnama JRahnama added this to the 2.0.0-preview3 milestone Apr 7, 2020
@JRahnama JRahnama added the Area\Tests Issues that are targeted to tests or test projects label Apr 7, 2020
cheenamalhotra
cheenamalhotra reviewed Apr 7, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra changed the title Remote executor Enable Diagnostic Source tests with remote executor Apr 8, 2020
cheenamalhotra
cheenamalhotra reviewed Apr 8, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra mentioned this pull request Apr 9, 2020
Merged
@JRahnama JRahnama requested a review from David-Engel April 9, 2020 17:10
karinazhou
karinazhou reviewed Apr 9, 2020
View reviewed changes
David-Engel
David-Engel reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the changes and it's cool that we are finally fixing this and bringing it in. I approve in general. I'll leave final review and approval to someone else.

@JRahnama JRahnama merged commit 8884f63 into dotnet:master Apr 13, 2020
@JRahnama JRahnama deleted the RemoteExecutor branch July 6, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@David-Engel David-Engel David-Engel left review comments

+2 more reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari left review comments

@karinazhou karinazhou karinazhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

None yet

Milestone

2.0.0-preview3

Development

Successfully merging this pull request may close these issues.

5 participants

@JRahnama @cheenamalhotra @David-Engel @karinazhou @DavoudEshtehari