Standardize Connection String properties for enhanced user experience #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
Public API 🆕
cheenamalhotra
force-pushed
the
connectionProps
branch
from
5c0dd5e to
16155da
Compare
JRahnama
reviewed
Apr 27, 2020
cheenamalhotra
requested review from
David-Engel,
DavoudEshtehari,
JRahnama and
karinazhou
David-Engel
approved these changes
May 18, 2020
|
@cheenamalhotra |
|
Thanks for trying out and capturing the issue, our tests covered this property but was limited to connection string builder, hence this got missed. #585 will fix this issue. Thanks! |
majorsilence
added a commit
to TownSuite/TownSuite.MultiTenant
that referenced
this pull request
Aug 29, 2023
…strings see dotnet/SqlClient#1780 and dotnet/SqlClient#534 Application Intent (previously ApplicationIntent) Connect Retry Count (previously ConnectRetryCount) Connect Retry Interval (previously ConnectRetryInterval) Pool Blocking Period (previously PoolBlockingPeriod) Multiple Active Result Sets (previously MultipleActiveResultSets) Multiple Subnet Failover (previously MultiSubnetFailover) Transparent Network IP Resolution (previously TransparentNetworkIPResolution) Trust Server Certificate (previously TrustServerCertificate)
|
This change introduced huge compat issues. System.Data.Client does not understand connection strings generated by Microsoft.Data.Client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some connection string properties are breaking the theme of connection string properties for SqlClient and end users need to track which connection string properties are spelled differently. This change standardizes the connection properties for better user experience.
The below connection properties are now updated with synonyms created for backwards compatibility:
ApplicationIntent)ConnectRetryCount)ConnectRetryInterval)PoolBlockingPeriod)MultipleActiveResultSets)MultiSubnetFailover)TransparentNetworkIPResolution)TrustServerCertificate)P.S. Also made some improvements on documentation.